On Mon, 21 May 2007 22:06:36 -0700
Junio C Hamano <[email protected]> wrote:
> This introduces a shared header file that defines the entries
> for two dma blacklists in ide-dma.c and libata-core.c to make it
> easier to keep them in sync.
>
> Signed-off-by: Junio C Hamano <[email protected]>
NAK
This makes stuff so much more ugly its not funny
> ---
>
> * Removes more lines than it adds. I am not proud of the
> DMA_BLACK_LIST macro in ide-dma.c which relies on the
> compiler doing a sane thing for compile time constant
> expression to initialize the list, but that hopefully can be
> fixed in the next patch.
The basic concept is sound but it would be better to make sure
the ATA_HORKAGE macros and struct ata_blacklist_entry as well as all the
blacklist stuff was placed together in one file to avoid the horrors you
are proposing and then used by both driver sets.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
