Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver

On Fri, 2007-05-25 at 10:36 +0200, [email protected] wrote:
> -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE)
> +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \
> +    defined(CONFIG_PS3_FLASH_MODULE) ||
> defined(CONFIG_PS3_FLASH_MODULE)

As I said multiple times, imho, #ifdef CONFIG_xxx_MODULE in the kernel
is always a bug.

You should always be able to build the module out of tree afteward and
use it on a kernel that didn't have the CONFIG_xxx_MODULE set imho.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
    • From: Geert Uytterhoeven <[email protected]>

• References:
  • [patch 0/7] RFC: PS3 Storage Drivers
    • From: [email protected]
  • [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
    • From: [email protected]

• Prev by Date: Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.
• Next by Date: Re: [patch 5/7] ps3: Disk Storage Driver
• Previous by thread: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
• Next by thread: Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]