Re: [PATCH] old declaration ritchie style fix

Jiri Slaby wrote:
> Yoann Padioleau napsal(a):
>>  static int
>> -receivepkt (target, buffer)
>> -	int target;
>> -	unsigned char *buffer;
>> +receivepkt (int target, unsigned char *buffer)
> 
> When you are at it, you can also get rid of bsd return-type-on-its-own-line
> style

return-type-on-its-own-line is IMO OK if it occurs consistently in a
file.  It can improve readability particularly if long return types are
combined with long function names.

> + remove the space before parenthesis.

Indeed.
-- 
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] old declaration ritchie style fix
    • From: Yoann Padioleau <[email protected]>
  • Re: [PATCH] old declaration ritchie style fix
    • From: Jiri Slaby <[email protected]>

• Prev by Date: [patch 6/7] ps3: ROM Storage Driver
• Next by Date: Re: [patch] x86_64: fix sched_clock()
• Previous by thread: Re: [PATCH] old declaration ritchie style fix
• Next by thread: [PATCH -mm] reiser4: remove lzo compression security hole
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]