Re: [patch] sched_clock(): cleanups

* Andi Kleen <[email protected]> wrote:

> > if (!f)
> > 	f = cpufreq_get(freq->cpu);
> > if (!f)
> > 	f = tsc_khz;
> > 
> > ?
> > 
> > Something's not quite right here :-)
> 
> What do you think is wrong? cpufreq_get can return 0.
> 
> Admittedly the second test could be inside a block of the first, but 
> then it would make the code more ugly and this code is not performance 
> critical.

moving it inside the block makes the code _cleaner_ in fact :-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] sched_clock(): cleanups
    • From: Ingo Molnar <[email protected]>

• References:
  • [patch] sched_clock(): cleanups
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] sched_clock(): cleanups
    • From: "Satyam Sharma" <[email protected]>
  • Re: [patch] sched_clock(): cleanups
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [patch] sched_clock(): cleanups
• Next by Date: Re: [patch] sched_clock(): cleanups
• Previous by thread: Re: [patch] sched_clock(): cleanups
• Next by thread: Re: [patch] sched_clock(): cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]