Re: [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 24 May 2007 12:33:23 +0200
Jarek Poplawski <jarkao2@o2.pl> wrote:

> 
> smpboot: cachesize comparison fix in smp_tune_scheduling()
> 
> boot_cpu_data.x86_cache_size is signed int and can be < 0 too.
> 
> PS: this function is removed from current -mm.
> 
> 
> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
> 
> ---
> 
> diff -Nurp 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c
> --- 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c	2007-05-24 09:37:11.000000000 +0200
> +++ 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c	2007-05-24 11:48:03.000000000 +0200
> @@ -948,7 +948,7 @@ static void smp_tune_scheduling(void)
>  	if (cpu_khz) {
>  		cachesize = boot_cpu_data.x86_cache_size;
>  
> -		if (cachesize > 0)
> +		if ((long)cachesize > 0)
>  			max_cache_size = cachesize * 1024;
>  	}
>  }

Under what conditions can boot_cpu_data.x86_cache_size be negative?

Have negative values of boot_cpu_data.x86_cache_size been observed in
practice?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/