Re: [PATCH 4/7] SMP: Implement on_one_cpu()

[Avi Kivity <avi@qumranet.com>]

Roland Dreier wrote:
> I don't see any documented restrictions about preemption being
> disabled when this function is called, but...
>
>  > +int on_one_cpu(int cpu, void (*func) (void *info), void *info,
>  > +	       int retry, int wait)
>  > +{
>  > +	int ret;
>  > +	int this_cpu;
>  > +
>  > +	this_cpu = get_cpu();
>
> what if a preempt and reschedule to a different CPU happens right
> here, after this_cpu is set?
>
>  > +	if (this_cpu == cpu) {
>   

get_cpu() disables preemption (the return value would be meaningless 
otherwise).


--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/