On Fri, May 18, 2007 at 12:01:08PM -0400, Dave Jones wrote: > On Fri, May 18, 2007 at 12:09:38AM -0400, Ed Sweetman wrote: [snip] > still has unnecessary whitespace changes [snip] > and still wordwrapped. > (also capitalise ACPI) I haven't seen any more e-mail traffic on this topic so I'm assuming that the ball has been dropped. Please excuse me if an acceptable patch has been submitted that I wasn't CC'd on. Here is cleaned up version of Ed's patch that I believe addresses Dave's stylistic concerns applies the relevant changes to both x86 & x86_64. Signed-off-by: Joshua Hoblitt <[email protected]> -- i386/kernel/cpu/cpufreq/Kconfig | 13 ++++++++++--- x86_64/kernel/cpufreq/Kconfig | 13 ++++++++++--- 2 files changed, 20 insertions(+), 6 deletions(-) diff -Nurp linux-2.6.22-rc1-mm1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig linux-2.6.22-rc1-mm1/arch/i386/kernel/cpu/cpufreq/Kconfig --- linux-2.6.22-rc1-mm1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-04-27 11:49:26.000000000 -1000 +++ linux-2.6.22-rc1-mm1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-21 16:20:47.000000000 -1000 @@ -90,10 +90,17 @@ config X86_POWERNOW_K8 If in doubt, say N. config X86_POWERNOW_K8_ACPI - bool - depends on X86_POWERNOW_K8 && ACPI_PROCESSOR - depends on !(X86_POWERNOW_K8 = y && ACPI_PROCESSOR = m) + bool "ACPI Support" + select ACPI_PROCESSOR + depends on X86_POWERNOW_K8 default y + help + This provides access to the K8s Processor Performance States via ACPI. + This driver is probably required for CPUFreq to work with multi-socket and + SMP systems. It is not required on at least some single-socket yet + multi-core systems, even if SMP is enabled. + + It is safe to say Y here. config X86_GX_SUSPMOD tristate "Cyrix MediaGX/NatSemi Geode Suspend Modulation" diff -Nurp linux-2.6.22-rc1-mm1.orig/arch/x86_64/kernel/cpufreq/Kconfig linux-2.6.22-rc1-mm1/arch/x86_64/kernel/cpufreq/Kconfig --- linux-2.6.22-rc1-mm1.orig/arch/x86_64/kernel/cpufreq/Kconfig 2007-05-21 16:11:16.000000000 -1000 +++ linux-2.6.22-rc1-mm1/arch/x86_64/kernel/cpufreq/Kconfig 2007-05-21 16:29:11.000000000 -1000 @@ -24,10 +24,17 @@ config X86_POWERNOW_K8 If in doubt, say N. config X86_POWERNOW_K8_ACPI - bool - depends on X86_POWERNOW_K8 && ACPI_PROCESSOR - depends on !(X86_POWERNOW_K8 = y && ACPI_PROCESSOR = m) + bool "ACPI Support" + select ACPI_PROCESSOR + depends on X86_POWERNOW_K8 default y + help + This provides access to the K8s Processor Performance States via ACPI. + This driver is probably required for CPUFreq to work with multi-socket and + SMP systems. It is not required on at least some single-socket yet + multi-core systems, even if SMP is enabled. + + It is safe to say Y here. config X86_SPEEDSTEP_CENTRINO tristate "Intel Enhanced SpeedStep (deprecated)"
Attachment:
pgpFGWkb8vLWB.pgp
Description: PGP signature
- Follow-Ups:
- References:
- [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Joshua Hoblitt <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Prakash Punnoor <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: "Duane Griffin" <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Dave Jones <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Joshua Hoblitt <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Ed Sweetman <[email protected]>
- Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- From: Dave Jones <[email protected]>
- [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- Prev by Date: [PATCH 3/3] rd: Simplify by using the same helper functions in libfs
- Next by Date: Re: [RFC] enhancing the kernel's graphics subsystem
- Previous by thread: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- Next by thread: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
- Index(es):
 |