Re: [stable] [PATCH] - fix oops in sysfs_readdir

Andrew Morton wrote:
> Actually, someone (eg distros) looking at Tejun's changelog would still be
> struggling to answer the question "do I need this".  The one thing it
> claims to fix is "duplicate inode numbers".  But why is that a problem? 
> What are the user-visible consequences of not merging the patch?  Unobvious.

The oops part is explained in #2.  sysfs_dirent->s_dentry can go away
anytime and the original code accesses it without any synchronization,
so it can end up dereferencing NULL or access already freed memory.
And, yeah, this is another place where reclaim-related oops occurs.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [stable] [PATCH] - fix oops in sysfs_readdir
    • From: Eric Sandeen <[email protected]>
  • Re: [stable] [PATCH] - fix oops in sysfs_readdir
    • From: Andrew Morton <[email protected]>
  • Re: [stable] [PATCH] - fix oops in sysfs_readdir
    • From: Eric Sandeen <[email protected]>
  • Re: [stable] [PATCH] - fix oops in sysfs_readdir
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [rfc] increase struct page size?!
• Next by Date: PCI device problem - MMCONFIG, cannot allocate resource region, resource collisions
• Previous by thread: Re: [stable] [PATCH] - fix oops in sysfs_readdir
• Next by thread: Re: [stable] [PATCH] - store sysfs inode nrs in s_ino to avoid readdir oopses
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]