Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 20 May 2007, Stefan Richter wrote:
> 
> > Note that this data structure only needs conversion on x86_64 and ia64, but
> > not on powerpc and other 64 bit architectures that align __u64 also in
> > 32 bit mode.
> 
> Is this conversion just unnecessary or actually harmful on ppc64 and others?

With the current patch, the compat_ioctl function does not handle the ppc32
version of the structure at all, so it's broken there, it would at least
need a 

	case RAW1394_IOC_GET_CYCLE_TIMER:
		err = raw1394_ioctl(NULL, file, cmd, arg);
		break;

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux