On Sun, 20 May 2007, David Rientjes wrote:
> On Sun, 20 May 2007, Robert P. J. Day wrote:
>
> > diff --git a/include/linux/moduleinfo.h b/include/linux/moduleinfo.h
> > new file mode 100644
> > index 0000000..cee86a9
> > --- /dev/null
> > +++ b/include/linux/moduleinfo.h
> > @@ -0,0 +1,18 @@
> > +#ifndef _LINUX_MODULEINFO_H
> > +#define _LINUX_MODULEINFO_H
> > +
> > +#ifdef MODULE
> > +#include <linux/stringify.h>
> > +#define ___module_cat(a,b) __mod_ ## a ## b
> > +#define __module_cat(a,b) ___module_cat(a,b)
> > +#define __MODULE_INFO(tag, name, info) \
> > +static const char __module_cat(name,__LINE__)[] \
> > + __attribute_used__ \
> > + __attribute__((section(".modinfo"),unused)) = __stringify(tag) "=" info
>
> This isn't a function definition so __attribute_used__ (which is
> deprecated anyway) doesn't mean anything. Please simply use
> __maybe_unused and remove "unused" from the second attribute.
i can do that as long as there's no way that those changes can (even
theoretically) make a difference in the build. in order to make sure
this patch didn't break anything, i went with a straight cut-and-paste
of the content to go into the new moduleinfo.h.
so while i agree that those changes shouldn't hurt, personally, i'd
prefer to just put this patch through as is and come back later to do
any tidying related to attribute rewording.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
