Re: [PATCH] MM : alloc_large_system_hash() can free some memory for non power-of-two bucketsize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



William Lee Irwin III a écrit :
On Fri, May 18, 2007 at 11:54:54AM +0200, Eric Dumazet wrote:
alloc_large_system_hash() is called at boot time to allocate space
for several large hash tables.
Lately, TCP hash table was changed and its bucketsize is not a
power-of-two anymore.
On most setups, alloc_large_system_hash() allocates one big page
(order > 0) with __get_free_pages(GFP_ATOMIC, order). This single
high_order page has a power-of-two size, bigger than the needed size.
We can free all pages that wont be used by the hash table.
On a 1GB i386 machine, this patch saves 128 KB of LOWMEM memory.
TCP established hash table entries: 32768 (order: 6, 393216 bytes)

The proper way to do this is to convert the large system hashtable
users to use some data structure / algorithm  other than hashing by
separate chaining.

No thanks. This was already discussed to death on netdev. To date, hash tables are a good compromise.

I dont mind losing part of memory, I prefer to keep good performance when handling 1.000.000 or more tcp sessions.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux