Re: [PATCH] ALPHA: MARVEL - check for allocated memory

[Cyrill Gorcunov <gorcunov@gmail.com>]

[Andrew Morton - Thu, May 17, 2007 at 10:31:13AM -0700]
| On Thu, 17 May 2007 18:37:12 +0400 Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > [Andrew Morton - Wed, May 16, 2007 at 11:44:55AM -0700]
| > | On Wed, 16 May 2007 22:12:14 +0400
| > | Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| > | 
| > | > This patch adds checking for allocated memory
| > | > which is used to hold AGP info. Also some whitespace
| > | > cleanup.
| > | 
| > | The inclusion of all the whitespace fixies makes it rather hard to
| > | see what the patch actually does.
| > | 
| > | I'm not sure that I can be bothered with this, really.  afaict the
| > | checks you're adding are for boot-time allocations which we tend
| > | to assume won't fail, and they're kmalloc(small-amount, GFP_KERNEL)
| > | which is basically infallible, and it only affects, err, alpha.
| > | 
| > 
| > So you think we could leave all as is? I mean sould I just drop the patch?
| 
| mutter.  I spose we should fix those sites which can be called at times other than
| system boot.  Often one can use the lack of __init annotation to work out if a site
| is being called after boot.
| 

Hi Andrew,

you know as I see marvel and titan (they are touched by my patches) only uses
kmalloc at boot time (as you mentoined) and there are no sites with unchecked
kmalloc calls after booting. So just forget about patches I sent ;)

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/