[PATCH] spi: potential memleak in spidev_ioctl

'ioc' should be deallocated if __copy_from_user fails (found by Coverity - CID 1644).

Signed-off-by: Florin Malita <[email protected]>
---

spidev.c |    1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index c0a6dce..2464f34 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -364,6 +364,7 @@ spidev_ioctl(struct inode *inode, struct file *filp,
			break;
		}
		if (__copy_from_user(ioc, (void __user *)arg, tmp)) {
+			kfree(ioc);
			retval = -EFAULT;
			break;
		}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: [PATCH 1/2] scalable rw_mutex
• Next by Date: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
• Previous by thread: bug seen with dynticks from CONFIG_HARDIRQS_SW_RESEND
• Next by thread: [PATCH] powernow-k8: depend on acpi-processor for SMP systems
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]