On Wed, 2007-05-16 at 01:33 +0530, Amit K. Arora wrote:
> This patch implements sys_fallocate() and adds support on i386, x86_64
> and powerpc platforms.
> @@ -1137,6 +1148,8 @@ struct inode_operations {
> ssize_t (*listxattr) (struct dentry *, char *, size_t);
> int (*removexattr) (struct dentry *, const char *);
> void (*truncate_range)(struct inode *, loff_t, loff_t);
> + long (*fallocate)(struct inode *inode, int mode, loff_t offset,
> + loff_t len);
> };
Does the return value from fallocate inode operation has to be *long*?
It's not consistent with the ext4_fallocate() define in patch 4/5,
+int ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t
len)
thus cause compile warnings.
Mingming
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc
- From: "Amit K. Arora" <[email protected]>
- Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc
- References:
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- Re: Interface for the new fallocate() system call
- From: Andreas Dilger <[email protected]>
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- Re: Interface for the new fallocate() system call
- From: Jakub Jelinek <[email protected]>
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- [PATCH 0/5] fallocate system call
- From: "Amit K. Arora" <[email protected]>
- [PATCH 0/5][TAKE3] fallocate system call
- From: "Amit K. Arora" <[email protected]>
- [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc
- From: "Amit K. Arora" <[email protected]>
- Re: Interface for the new fallocate() system call
- Prev by Date: Re: [PATCH 2/2] AFS: Implement shared-writable mmap
- Next by Date: Re: [PATCH 2/5] Use mutex instead of semaphore in IDE driver
- Previous by thread: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc
- Next by thread: Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc
- Index(es):
 |