On Tue, May 15, 2007 at 09:00:32AM -0700, Andrew Morton wrote:
> On Tue, 15 May 2007 14:24:40 +0200 Christoph Hellwig <[email protected]> wrote:
>
> > Recent builds get tons of warnings about memclear_highpage_flush
> > beeing deprecated. Turns out it's replaced by zero_user_page
> > which takes an additional argument.
> >
> > Now folks, deprecated is for actual functionality going away, there
> > is no need to mark the old name deprecated for such a trivial
> > paramter change and rename.
>
> Yes, it's rather trivial, but memclear_highpage_flush() *is* going away.
Well, it's renamed to zero_user_page and gained an argument. We do
changed like that all the time and don't put silly deprecation warnings
in.
> > Here's a patch to kill memclear_highpage_flush and convert the reaming
> > user to make the build a littler more silent, it's more than noisy
> > enough due to all the useless addition of __deprecated or __must_check
> > to widely used functionality and gcc stupid false positives.
>
> Patches have been prepared which convert all in-kernel users. I thought
> I'd dtrt and feed them through maintainers, but that takes time. The
> laggards are on cc ;)
No, there is absolutely no point in feeding this through maintainers.
For something as trivial as a rename and adding an argument doing one
patch is enough and the right thing. We can't feed any trivial global
search & replace through maintainer and generate warnings in the
meantime.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]