On Mon, 14 May 2007 16:46:17 -0700 (PDT)
Christoph Lameter <[email protected]> wrote:
> -#define KMALLOC_SHIFT_HIGH 25
> +#define KMALLOC_SHIFT_HIGH ((MAX_ORDER + PAGE_SHIFT) =< 25 ? \
> + MAX_ORDER + PAGE_SHIFT - 1 : 25)
Would prefer to see a lot more parentheses in there. Who knows what the arch
is using for MAX_ORDER and PAGE_SHIFT.
> #if !defined(CONFIG_MMU) || NR_CPUS > 512 || MAX_NUMNODES > 256
> #define KMALLOC_SHIFT_HIGH 20
> @@ -86,6 +87,9 @@ static inline int kmalloc_index(int size
> */
> WARN_ON_ONCE(size == 0);
>
> + if (size >= (1UL << KMALLOC_SHIFT_HIGH))
> + return -1;
> +
`size' is `int'. Deliberately comparing it to an unsigned long seems
unpointful.
Arguably, `size' should be size_t.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
