Re: [PATCH 1/2] non-string based tsc unstable reasons

On Saturday 12 May 2007 17:43:45 Daniel Walker wrote:
> Just passing a string to mark_tsc_unstable() doesn't allow real code to change
> based on the reason for the instablility. I changed mark_tsc_unstable()
> to accept a string and a flag which denotes a general reason why the tsc
> is unstable, and can be evaluated in code.
> 
> This is based off John Stultz patch to add the string reasons.

This seems ugly -- it would be better to just do whatever needs to
be doing in the caller instead of passing down a enum and then switch.

And why do you really need it anyways?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] non-string based tsc unstable reasons
    • From: Daniel Walker <[email protected]>

• References:
  • [PATCH 1/2] non-string based tsc unstable reasons
    • From: Daniel Walker <[email protected]>

• Prev by Date: Re: [PATCH 2/2] i386: sched_clock() follows percpu frequency changes
• Next by Date: Re: [Bug 8464] New: autoreconf: page allocation failure. order:2, mode:0x84020
• Previous by thread: Re: [PATCH 2/2] i386: sched_clock() follows percpu frequency changes
• Next by thread: Re: [PATCH 1/2] non-string based tsc unstable reasons
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]