Re: [PATCH] update sysfs kset initialisation in PPC64 DLPAR IO driver

[Michael Ellerman <michael@ellerman.id.au>]

On Fri, 2007-05-11 at 11:40 +0100, Andy Whitcroft wrote:
> Michael Ellerman wrote:
> > On Fri, 2007-05-11 at 00:16 -0700, Greg KH wrote:
> >> On Thu, May 10, 2007 at 04:54:41PM +0100, Andy Whitcroft wrote:
> >>> Greg KH wrote:
> >>>> On Thu, May 10, 2007 at 03:00:50PM +0100, Andy Whitcroft wrote:
> >>>>> Move the rpadlpar device from "struct subsystem" to "struct kset"
> >>>>> following the changes in sysfs.
> >>>>>
> >>>>> Signed-off-by: Andy Whitcroft <apw@shadowen.org>
> >>>>> ---
> >>>>>
> >>>>> 	Ok, this patch seems to sort out the compile problem
> >>>>> 	here and indeed boots and runs kernbench.  Perhaps
> >>>>> 	you could confirm this is sufficient.
> >>>> As per the discussion on the pci hotplug list, no, this doesn't seem to
> >>>> fix the problem.  The developers there are looking into it.  If you can
> >>>> test out patches for this, I'm sure the people there would appreciate
> >>>> the help.
> >>> Sure anything they have for testing, send them to me ...
> >> They have the same patch that you made (I made it), yet they reported
> >> that it didn't work properly for them.
> >>
> >> Can you test your patch out on "real" hardware?
> > 
> > I tested it on real hardware, but it can't hurt for Andy to try it too I
> > guess.
> 
> To be fair I am not sure I have a clue how to test it.  Got a recipe?
> My patch was based on how other drivers seemed to be converted which is
> a concern for those drivers.
> 
> What sort of failure do you see?

Prior to the removal of struct subysystem I get two files called
'add_slot' and 'remove_slot' under /sys/bus/pci/slots/control.

With Greg's patch I get the directory /sys/bus/pci/slots/control, but
nothing under it. 

Apparently John Rose is looking into it.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Attachment: signature.asc
Description: This is a digitally signed message part