Re: [patch 7/7] tidy up usermode helper waiting a bit

[Johannes Berg <johannes@sipsolutions.net>]

[/me wonders why he was CC'ed]

>  	/* CLONE_VFORK: wait until the usermode helper has execve'd
>  	 * successfully We need the data structures to stay around
>  	 * until that is done.  */
> -	if (wait)
> +	if (wait == UMH_WAIT_PROC)
>  		pid = kernel_thread(wait_for_helper, sub_info,
>  				    CLONE_FS | CLONE_FILES | SIGCHLD);
>  	else
>  		pid = kernel_thread(____call_usermodehelper, sub_info,
>  				    CLONE_VFORK | SIGCHLD);

Isn't that a change in behaviour? Previously it said
	if (wait)
 <=>	if (wait != 0)
 <=>	if (wait != UMH_WAIT_EXEC)
or am I missing something?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part