Re: [2.6.22 PATCH 22/26] dm: bio list helpers

On May 9 2007 08:49, Jens Axboe wrote:
>On Tue, May 08 2007, Andrew Morton wrote:
>> > +#define bio_list_for_each(bio, bl) \
>> > +	for (bio = (bl)->head; bio && ({ prefetch(bio->bi_next); 1; }); \
>> > +	     bio = bio->bi_next)
>> > +
>
>Besides, manual prefetching is very rarely a win. I dabbled with some
>benchmarks a few weeks back (with the doubly linked lists), and in most
>cases it was actually a loss. So I'd vote for just removing the
>prefetch() above.

So is the prefetching in the basic ADTs (e.g. linux/list.h) a loss too?



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6.22 PATCH 22/26] dm: bio list helpers
    • From: Alan Cox <[email protected]>

• References:
  • [2.6.22 PATCH 22/26] dm: bio list helpers
    • From: Alasdair G Kergon <[email protected]>
  • Re: [2.6.22 PATCH 22/26] dm: bio list helpers
    • From: Andrew Morton <[email protected]>
  • Re: [2.6.22 PATCH 22/26] dm: bio list helpers
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: [2.6.22 PATCH 22/26] dm: bio list helpers
• Next by Date: why are we reduce spin-lock and replace it with lock-free?
• Previous by thread: Re: [2.6.22 PATCH 22/26] dm: bio list helpers
• Next by thread: Re: [2.6.22 PATCH 22/26] dm: bio list helpers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]