Re: [PATCH 3/3] AFS: Implement basic file write support

Nick Piggin <[email protected]> wrote:

> Why do you call SetPageUptodate when the page is not up to date?
> That leaks uninitialised data, AFAIKS.

It only seems that way.  If afs_prepare_write() is called, but doesn't return
an error, then afs_commit_write() will be called, and it seems that the copy
in of the data will be guaranteed not to fail by the caller.

Furthermore, afs_prepare_page() will have filled in the missing bits.

And whilst all that is going on, the page lock will be help by the caller, so
that no-one else can access the partially complete page.

I suppose I could call SetPageUptodate() in afs_commit_write() instead.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] AFS: Implement basic file write support
    • From: Nick Piggin <[email protected]>

• References:
  • Re: [PATCH 3/3] AFS: Implement basic file write support
    • From: Nick Piggin <[email protected]>
  • [PATCH 1/3] AFS: Export a couple of core functions for AFS write support
    • From: David Howells <[email protected]>
  • [PATCH 3/3] AFS: Implement basic file write support
    • From: David Howells <[email protected]>

• Prev by Date: Re: include files: convert "include" subdirectory to UTF-8
• Next by Date: [PATCH] NLM program ID for user space NLM server
• Previous by thread: Re: [PATCH 3/3] AFS: Implement basic file write support
• Next by thread: Re: [PATCH 3/3] AFS: Implement basic file write support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]