Re: [PATCH 002 of 2] md: Improve the is_mddev_idle test

On May 10 2007 16:22, NeilBrown wrote:
>
>diff .prev/drivers/md/md.c ./drivers/md/md.c
>--- .prev/drivers/md/md.c	2007-05-10 15:51:54.000000000 +1000
>+++ ./drivers/md/md.c	2007-05-10 16:05:10.000000000 +1000
>@@ -5095,7 +5095,7 @@ static int is_mddev_idle(mddev_t *mddev)
> 		 *
> 		 * Note: the following is an unsigned comparison.
> 		 */
>-		if ((curr_events - rdev->last_events + 4096) > 8192) {
>+		if ((long)curr_events - (long)rdev->last_events > 4096) {
> 			rdev->last_events = curr_events;
> 			idle = 0;
> 		}

What did really change? Unless I am seriously mistaken,

    curr_events - last_evens + 4096 > 8192

is mathematically equivalent to

    curr_events - last_evens        > 4096

The casting to (long) may however force a signed comparison which turns
things quite upside down, and the comment does not apply anymore.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 002 of 2] md: Improve the is_mddev_idle test
    • From: Neil Brown <[email protected]>

• References:
  • [PATCH 000 of 2] md: Two more bugfixes.
    • From: NeilBrown <[email protected]>
  • [PATCH 002 of 2] md: Improve the is_mddev_idle test
    • From: NeilBrown <[email protected]>

• Prev by Date: Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux
• Next by Date: pte_{ex,rd}protect
• Previous by thread: Re: [PATCH 002 of 2] md: Improve the is_mddev_idle test
• Next by thread: Re: [PATCH 002 of 2] md: Improve the is_mddev_idle test
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]