Re: remove broken URLs from net drivers' output

[Adrian Bunk <bunk@stusta.de>]

On Thu, May 10, 2007 at 12:22:59AM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> I thought it was just an informal tag to mark which people did agree with 
>> the patch (and the line between your "Makes good sense to me." and a "Feel 
>> free to add my ACK to this" is really thin).
>
> No, the line is easy and obvious:  if there is any doubt, DO NOT ASSUME.
> 
> If they do not explicitly ACK it, then do not presume to speak for them.

There is no doubt that Jesper did explicitly ACK the patch.
We are ONLY discussing whether his informal ACK can be translated into 
an "Acked-by:" line.

The line I mentioned only exists if "Acked-by:" is considered a formal 
tag someone must explicitely give, and not an informal indication that 
someone agrees with the patch. But in this case, we should better 
require people to give explicit "Acked-by:" lines, like we already 
require for "Signed-off-by:" lines.

I've seen many cases where people other than me added "Acked-by:" tags 
when there was only a "Makes good sense to me." or "Fine with me.", but 
no formal "Acked-by:" given.

If "Acked-by:" should be considered a formal tag, it
- should be documented in Documentation/SubmittingPatches and
- the practice must change to always require people to give
  a formal "Acked-by:".

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/