Re: [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues

Robert Hancock wrote:

This patch fixes some problems with ADMA-capable controllers with regard to freeze, thaw and irq_clear libata callbacks. Freeze and thaw didn't switch the ADMA-specific interrupts on or off, and more critically the irq_clear function didn't respect the restriction that the notifier clear registers for both ports have to be written at the same time even when only one port is being cleared. This could result in

timeouts on one port when error handling (i.e. as a result of hotplug)
occurred on the other port.

As well, this fixes some issues in the interrupt handler: we shouldn't check any ADMA status if the port has ADMA switched off because of an ATAPI device, and it also checks to see if any ADMA interrupt has been raised even when we are in

port-register mode.

Signed-off-by: Robert Hancock <[email protected]>

applied

please properly word-wrap your patch descriptions in the future


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues
    • From: Robert Hancock <[email protected]>

• Prev by Date: Re: [bisect] NFS regression breaks X
• Next by Date: Re: [PATCH] Fix pata_qdi.c probe code
• Previous by thread: [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues
• Next by thread: [PATCH -mm] libata-core: convert to use cancel_rearming_delayed_work()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]