Re: [patch 7/9] lguest: the net driver

On Thu, May 10, 2007 at 01:14:55AM +1000, Rusty Russell wrote:
> > > +	info->peer = (void *)ioremap(info->peer_phys, info->mapsize);
> > 
> > check for NULL
> 
> Erk, good catch!

Also the cast is bogus.  ioremap already returns void already.  Even
more importantly the lack of the __iomem annotations shows that either this
code hasn't been run through sparse or someone decided to ignore it's
errors.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 7/9] lguest: the net driver
    • From: [email protected]
  • Re: [patch 7/9] lguest: the net driver
    • From: Jeff Garzik <[email protected]>
  • Re: [patch 7/9] lguest: the net driver
    • From: Rusty Russell <[email protected]>

• Prev by Date: 2.6.21-mm2: power_supply_core.c build failure
• Next by Date: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?
• Previous by thread: Re: [patch 7/9] lguest: the net driver
• Next by thread: Re: [patch 7/9] lguest: the net driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]