On Wed, May 09 2007, Pekka Enberg wrote:
> On 5/9/07, [email protected] <[email protected]> wrote:
> >+/* Jens gave me this nice helper to end all chunks of a request. */
> >+static void end_entire_request(struct request *req, int uptodate)
> >+{
> >+ if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> >+ BUG();
> >+ add_disk_randomness(req->rq_disk);
> >+ blkdev_dequeue_request(req);
> >+ end_that_request_last(req, uptodate);
> >+}
>
> Again, I would prefer this went straight into block/ll_rw_blk.c. Rene
> and I am using something similar in the new Mitsumi driver although
> one of us has a bug already, we're using req->nr_sectors for this...
Lets do it after it is merged, as not to create a hold-up point for
lguest. Once it's in, I'll fix it up.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
