Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Hi,

On Mon, 7 May 2007, Krzysztof Halasa wrote:

> Roman Zippel <[email protected]> writes:
> 
> > HDLC doesn't really look like simple library code, what's up with all the 
> > HDLC_* options?
> 
> Sub-modules.

So it's not simple library code, or is it?

> Anyway, what does the patch "screw" exactly?

Normal dependencies, you basically have to manually make sure they are 
correct (and it seems with your patch they aren't). Again, _please_ (with 
sugar on top) don't use select unless you have a good reason for it.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>
  • [PATCH] Use menuconfig objects II - netdev/wan
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: "Satyam Sharma" <[email protected]>

• References:
  • [PATCH 0/3] Intel IXP4xx network drivers
    • From: Krzysztof Halasa <[email protected]>
  • [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
    • From: Krzysztof Halasa <[email protected]>

• Prev by Date: Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6)
• Next by Date: Re: [PATCH 3/3] Intel IXP4xx network drivers
• Previous by thread: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
• Next by thread: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]