Re: [linux-dvb] [PATCH] dvb-core: Handle failures to create devices

[Simon Arlott <simon@fire.lp0.eu>]

On 06/05/07 23:50, Trent Piepho wrote:
> I've tested this and can confirm it works.  dvb_class will be set too late
> without the change to subsys_initcall.
>
> On Tue, 1 May 2007, Simon Arlott wrote:
> > dvb-core is not started early enough when device drivers that use dvb are
> > compiled in so device_register_device fails (silently) since dvb_class is
>
>                 ^dvb_register_device
>
> > NULL, this runs dvb_init using subsys_initcall instead of module_init.
> >
> > dvb_register_device will now check the return value of class_device_create.
> > All the printks had missing level prefixes so I've fixed these too.
>
> Probably better to make this a separate patch, since it's not related.
>
> > -		printk ("%s: could get find free device id...\n", __FUNCTION__);
> > +		printk(KERN_ERR "%s: could get find free device id...\n", __FUNCTION__);
>
> "couldn't find free device id"
>
> If it's ok with you, I'll import your patch as two seperate patches with
> the spelling errors fixed?

That's fine with me.

> > +	dprintk(KERN_DEBUG "DVB: register adapter%d/%s%d @ minor: %i (0x%02x)\n",
> >  		adap->num, dnames[type], id, nums2minor(adap->num, type, id),
> >  		nums2minor(adap->num, type, id));
>
> The dvb-core dvbdev_debug parameter does nothing but turn on this one
> single dprintk.  I'm tempted to just delete it.

Just always output that information, or remove it? (I have it enabled, 
although I'm not sure if there's any point).

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/