Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters

On Fri, 04 May 2007 15:30:57 +0100
James Pearson <[email protected]> wrote:

> /proc/PID/environ currently truncates at 4096 characters, patch based on 
> the /proc/PID/mem code.
> 
> Signed-off-by: James Pearson <[email protected]>
>

What about latency when reading one *big* environ ?

Dont we need some cond_resched() test in the loop ?

> +
> +static struct file_operations proc_environ_operations = {
> +       .read           = environ_read,
> +};
> +

Please use the const qualifier here :

static const struct file_operations ...

Thank you

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters
    • From: James Pearson <[email protected]>

• References:
  • [PATCH] Don't truncate /proc/PID/environ at 4096 characters
    • From: James Pearson <[email protected]>

• Prev by Date: Re: [PATCH] change global zonelist order v4 [0/2]
• Next by Date: Re: console font limits
• Previous by thread: [PATCH] Don't truncate /proc/PID/environ at 4096 characters
• Next by thread: Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]