Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().

On Sat, 28 Apr 2007 06:23:54 -0400 (EDT) "Robert P. J. Day" <[email protected]> wrote:

> Replace the MAJOR() macro invocation with a call to the inline
> imajor() routine.
> 
> Signed-off-by: Robert P. J. Day <[email protected]>
> 
> ---
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 6b5b642..08da15b 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -710,7 +710,7 @@ static inline int is_loop_device(struct file *file)
>  {
>  	struct inode *i = file->f_mapping->host;
> 
> -	return i && S_ISBLK(i->i_mode) && MAJOR(i->i_rdev) == LOOP_MAJOR;
> +	return i && S_ISBLK(i->i_mode) && imajor(i) == LOOP_MAJOR;
>  }

there's no runtime change, and I count a couple hundred MAJORs in the tree.

I don't want to receive 200 one-line patches please.  If you're going to
do this then please do decent-sized per-subsystem patches and see if you can
persuade the subsystem maintainers to take them directly.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().
    • From: "Robert P. J. Day" <[email protected]>

• References:
  • [PATCH] Rewrite the MAJOR() macro as a call to imajor().
    • From: "Robert P. J. Day" <[email protected]>

• Prev by Date: Re: [-mm Patch]nbd: check the return value of sysfs_create_file
• Next by Date: Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)
• Previous by thread: [PATCH] Rewrite the MAJOR() macro as a call to imajor().
• Next by thread: Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]