Andrew Morton writes: > On Thu, 26 Apr 2007 23:33:32 +0530 "Amit K. Arora" <[email protected]> wrote: > > > This patch implements the fallocate() system call and adds support for > > i386, x86_64 and powerpc. > > > > ... > > > > +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) > > Please add a comment over this function which specifies its behaviour. > Really it should be enough material from which a full manpage can be > written. This looks like it will have the same problem on s390 as sys_sync_file_range. Maybe the prototype should be: asmlinkage long sys_fallocate(loff_t offset, loff_t len, int fd, int mode) Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- From: Suparna Bhattacharya <[email protected]>
- Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- References:
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- Re: Interface for the new fallocate() system call
- From: Andreas Dilger <[email protected]>
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- Re: Interface for the new fallocate() system call
- From: Jakub Jelinek <[email protected]>
- Re: Interface for the new fallocate() system call
- From: "Amit K. Arora" <[email protected]>
- [PATCH 0/5] fallocate system call
- From: "Amit K. Arora" <[email protected]>
- [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- From: "Amit K. Arora" <[email protected]>
- Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- From: Andrew Morton <[email protected]>
- Re: Interface for the new fallocate() system call
- Prev by Date: Re: [linux-dvb] Re: DST/BT878 module customization (.. was: Critical points about ...)
- Next by Date: Re: Routing 600+ vlan's via linux problems (looks like arp problems)
- Previous by thread: Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- Next by thread: Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
- Index(es):
 |