Re: dead CONFIG_ variables: drivers/video/

["Robert P. J. Day" <rpjday@mindspring.com>]

On Thu, 3 May 2007, Antonino A. Daplas wrote:

> On Thu, 2007-05-03 at 06:40 -0400, Robert P. J. Day wrote:
> > $ ../dead_config.sh drivers/video
> > ========== FB_68328_INVERT ==========
> > drivers/video/68328fb.c:53:#if defined(CONFIG_FB_68328_INVERT)
>
> Can be made part of Kconfig, I think
>
> > ========== FB_AU1200_DEVS ==========
> > drivers/video/au1200fb.c:52:#ifndef CONFIG_FB_AU1200_DEVS
> > drivers/video/au1200fb.c:53:#define CONFIG_FB_AU1200_DEVS 4
> > drivers/video/au1200fb.c:160:static struct au1200fb_device _au1200fb_devices[CONFIG_FB_AU1200_DEVS];
> > drivers/video/au1200fb.c:714:   for (i = 0; i < CONFIG_FB_AU1200_DEVS; ++i) {
> > drivers/video/au1200fb.c:1635:  for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane) {
> > drivers/video/au1200fb.c:1730:  for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane)
> > drivers/video/au1200fb.c:1850:                  for (plane = 0; plane < CONFIG_FB_AU1200_DEVS; ++plane)         {
>
> Not sure about this one.
>
> > ========== FB_MATROX_32MB ==========
> > drivers/video/matrox/matroxfb_base.c:307:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:327:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:339:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:1342:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.c:1619:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_DAC1064.c:1053:#ifdef CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.h:58:#define CONFIG_FB_MATROX_32MB
> > drivers/video/matrox/matroxfb_base.h:466:#ifdef CONFIG_FB_MATROX_32MB
>
> This needs to be part of Kconfig.
>
> > ========== FB_NVIDIA_DEBUG ==========
> > drivers/video/nvidia/nvidia.c:40:#undef CONFIG_FB_NVIDIA_DEBUG
> > drivers/video/nvidia/nvidia.c:41:#ifdef CONFIG_FB_NVIDIA_DEBUG
> > drivers/video/nvidia/nvidia.c:50:#ifdef CONFIG_FB_NVIDIA_DEBUG
>
> False positive, may be renamed.
>
> > ========== FB_SOFT_CURSOR ==========
> > drivers/video/sis/sis_main.c:1906:#ifdef CONFIG_FB_SOFT_CURSOR
>
> This is dead, FB_SOFT_CURSOR is truly gone.
>
> Thanks.


um ... just so there's no misunderstanding, *i* don't plan on fixing
any of this, i'm just running the script and reporting it.  i'm
assuming the respective maintainers can take it from here.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/