Re: dead CONFIG_ variables: drivers/scsi/

["Robert P. J. Day" <rpjday@mindspring.com>]

On Thu, 3 May 2007, Russell King wrote:

> On Thu, May 03, 2007 at 06:10:28AM -0400, Robert P. J. Day wrote:
> >
> > $ ../dead_config.sh drivers/scsi
> > ========== ACORNSCSI_CONSTANTS ==========
> > drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CONSTANTS
> > drivers/scsi/arm/acornscsi.c:417:#ifdef CONFIG_ACORNSCSI_CONSTANTS
> > drivers/scsi/arm/acornscsi.c:495:#ifdef CONFIG_ACORNSCSI_CONSTANTS
> > ========== SCSI_ACORNSCSI_LINK ==========
> > drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:169:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:1675:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:2849:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:2880:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
>
> False positives.  That #undef is preceded by a comment describing the
> driver-internal configuration for developers rather than users.  I
> guess they shouldn't be preceded by CONFIG_.

i've already admitted that this script is going to generate false
positives for a number of reasons, the most common one being using the
"CONFIG_" prefix outside the context of Kconfig.

technically, of course, that doesn't hurt but it sure would make the
code clearer if that prefix was officially reserved for Kconfig stuff.

rday

p.s.  "CONFIG_" prefix aside, i would think it's also a bit yucky to
be checking for the definition of a preprocessor symbol that you've
already hardcoded out of existence in the same source file.  :-)

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/