[PATCH] Remove unnecessary irq disabling

RR asks us if it is really necessary to disable interrupts in
setup_secondary_APIC_clock(). The answer is no, since setup_APIC_timer()
starts by saving irq flags, which also disables them.

Signed-off-by: Glauber de Oliveira Costa <[email protected]>

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 124b2d2..7eacd5f 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -875,9 +875,7 @@ void __init setup_boot_APIC_clock (void)
 
 void __cpuinit setup_secondary_APIC_clock(void)
 {
-	local_irq_disable(); /* FIXME: Do we need this? --RR */
 	setup_APIC_timer(calibration_result);
-	local_irq_enable();
 }
 
 void disable_APIC_timer(void)

---

• Follow-Ups:
  • Re: [PATCH] Remove unnecessary irq disabling
    • From: Mark Lord <[email protected]>

• Prev by Date: Re: Ext3 vs NTFS performance
• Next by Date: [PATCH] doc: fix oops-tracing duplicate
• Previous by thread: [patch] CFS scheduler, -v8
• Next by thread: Re: [PATCH] Remove unnecessary irq disabling
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]