Re: [PATCH 4/5] jffs2: Allow selection of compression mode via a sysfs attribute

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 01 May 2007 15:47:19 +0100 Richard Purdie wrote:

> Allow selection of the compression mode for jffs2 via a sysfs
> attribute. This establishes a sysfs presence for jffs2 through
> which other compression options could easily be exported too.
> 
> Signed-off-by: Richard Purdie <rpurdie@openedhand.com>
> ---
>  fs/Kconfig       |    9 ++++++++
>  fs/jffs2/compr.c |   41 ++++++++++++++++++++++++++++++++++++
>  fs/jffs2/compr.h |    6 +++++
>  fs/jffs2/super.c |   61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 117 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 328a62f..9da136b 100644
> diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c
> index fdb0efd..8c57dc7 100644
> --- a/fs/jffs2/compr.c
> +++ b/fs/jffs2/compr.c
> @@ -11,6 +11,7 @@
>   *
>   */
>  
> +#include <linux/kobject.h>

is that used/needed in this source file?

>  #include "compr.h"
>  
>  static DEFINE_SPINLOCK(jffs2_compressor_list_lock);
> @@ -296,6 +297,46 @@ int jffs2_unregister_compressor(struct jffs2_compressor *comp)
>          return 0;
>  }
>  
> +#ifdef CONFIG_JFFS2_SYSFS
> +
> +char *jffs2_get_compression_mode_name(void)
> +{
> +        switch (jffs2_compression_mode) {
> +        case JFFS2_COMPR_MODE_NONE:
> +                return "none";
> +        case JFFS2_COMPR_MODE_PRIORITY:
> +                return "priority";
> +        case JFFS2_COMPR_MODE_SIZE:
> +                return "size";
> +	case JFFS2_COMPR_MODE_FAVOURLZO:
> +		return "favourlzo";
> +        }
> +        return "unkown";

Lots of whitespace damage above (needs tabs).

> +}
> +
> +int jffs2_set_compression_mode_name(const char *name)
> +{
> +        if (!strncmp("none", name, 4)) {
> +                jffs2_compression_mode = JFFS2_COMPR_MODE_NONE;
> +                return 0;
> +        }
> +        if (!strncmp("priority", name, 8)) {
> +                jffs2_compression_mode = JFFS2_COMPR_MODE_PRIORITY;
> +                return 0;
> +        }
> +        if (!strncmp("size", name, 4)) {
> +                jffs2_compression_mode = JFFS2_COMPR_MODE_SIZE;
> +                return 0;
> +        }
> +	if (!strncmp("favourlzo", name, 9)) {
> +		jffs2_compression_mode = JFFS2_COMPR_MODE_FAVOURLZO;
> +		return 0;
> +	}
> +        return -EINVAL;

Lots of tabs needed above also.

> +}
> +
> +#endif
> +
>  void jffs2_free_comprbuf(unsigned char *comprbuf, unsigned char *orig)
>  {
>          if (orig != comprbuf)


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/