(We went off-list just now. Adding lkml again.)
On 5/1/07, Tejun Heo <[email protected]> wrote:
Satyam Sharma wrote:
> On 4/28/07, Tejun Heo <[email protected]> wrote:
>> Implement bin_buffer which contains a mutex and pointer to PAGE_SIZE
>> buffer to properly synchronize accesses to per-openfile buffer and
>> prepare for immediate-kobj-disconnect.
>>
>> Signed-off-by: Tejun Heo <[email protected]>
>> ---
>> [...]
>> @@ -135,14 +160,22 @@ static int open(struct inode * inode, struct
>> file * file)
>> goto Error;
>>
>> error = -ENOMEM;
>> - file->private_data = kmalloc(PAGE_SIZE, GFP_KERNEL);
>> - if (!file->private_data)
>> + bb = kzalloc(sizeof(*bb), GFP_KERNEL);
>> + if (!bb)
>> goto Error;
>>
>> + bb->buffer = kmalloc(PAGE_SIZE, GFP_KERNEL);
>
> You could simply do a __get_free_page() here instead of a
> kmalloc(PAGE_SIZE).
Yes, I could but 1. the original code was done using kmalloc
Yes, I saw that, but you could change it just as well. In any case,
this will only make fs/sysfs/bin.c similar to what is being done in
fs/sysfs/file.c. We allocate the buffer page backing the attribute's
data in fill_read_buffer() and fill_write_buffer() using
get_zeroed_page() and not kzalloc().
2. I'm not sure __get_free_page() is better than kmalloc(PAGE_SIZE, ), is it?
If you know for sure that you require *exactly* PAGE_SIZE bytes, then
yes, it is.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
