Re: [PATCH 2/9] Containers (V9): Example CPU accounting subsystem

[email protected] wrote:

+
+/* Lazily update the load calculation if necessary. Called with ca locked */
+static void cpuusage_update(struct cpuacct *ca)
+{
+	u64 now = get_jiffies_64();
+	/* If we're not due for an update, return */
+	if (ca->next_interval_check > now)
+		return;
+
+	if (ca->next_interval_check <= (now - INTERVAL)) {

These two conditions seem a little confusing.

If ca->next_interval_check > (now - INTERVAL), the else part
is executed, but if ca->next_interval_check > (now - INTERVAL)
then ca->next_interval_check > now, which implies we return
and never enter the else part. It's been quite sometime since
I looked at this code, so I might have gotten it wrong.
I see a load of 0% on my powerpc box. I think it is because
last_interval_time is always 0, I'll debug further


--
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/9] Containers (V9): Generic Process Containers
    • From: [email protected]
  • [PATCH 2/9] Containers (V9): Example CPU accounting subsystem
    • From: [email protected]

• Prev by Date: Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.
• Next by Date: Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.
• Previous by thread: [PATCH 2/9] Containers (V9): Example CPU accounting subsystem
• Next by thread: [PATCH 8/9] Containers (V9): Share css_group arrays between tasks with same container memberships
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]