Re: [1/3] dynamically allocate IRQ stacks

> +static void * __init __alloc_irqstack(int cpu)
> +{
> +	if (!cpu)
> +		return __alloc_bootmem(THREAD_SIZE, THREAD_SIZE,
> +						__pa(MAX_DMA_ADDRESS));
> +
> +	return (void *)__get_free_pages(GFP_KERNEL,
> +					ilog2(THREAD_SIZE/PAGE_SIZE));
> +}

I think you should test for slab_is_available() instead of checking
if the cpu number is 0.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [1/3] dynamically allocate IRQ stacks
    • From: Bill Irwin <[email protected]>

• References:
  • [0/3] i386 stack handling updates
    • From: Bill Irwin <[email protected]>
  • [1/3] dynamically allocate IRQ stacks
    • From: Bill Irwin <[email protected]>

• Prev by Date: [PATCH, try2] Add support for picopower irq router
• Next by Date: Re: console font limits
• Previous by thread: Re: [3/3] use vmalloc() to arrange guard pages for stacks
• Next by thread: Re: [1/3] dynamically allocate IRQ stacks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]