Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.

[Linus Torvalds <torvalds@linux-foundation.org>]

On Tue, 1 May 2007, Geert Uytterhoeven wrote:
> 
> This causes a compile failure on m68k:
> 
> | linux/fs/afs/fsclient.c: In function 'afs_deliver_fs_fetch_data':
> | linux/fs/afs/fsclient.c:269: warning: dereferencing 'void *' pointer
> | linux/fs/afs/fsclient.c:269: error: request for member 'virtual' in something not a structure or union
> 
> Probably you wanted to assign call->reply3 to a struct page pointer first, like you do for the call->unmarshall == 2 case.

Hmm. Wouldn't it be nicer to make "kmap_atomic()" be an inline function 
instead? That way, if you pass it a "void *", it still just works, and you 
get a much nicer/more readable error message too when the types actually 
don't match?

Of course, there may be some reason why <linux/highmem.h> does those with 
#define's rather than inline functions. Maybe "page_address()" or 
"pagefault_disabled()" is not declared at that point, and asking it to be 
declared might cause header file inclusion recursion?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/