On Mon, Apr 30, 2007 at 02:13:16PM +0200, Andi Kleen wrote:
> Actually looking at the code it would need some fixes first:
> /*
> * These should really be __section__(".bss.page_aligned") as well, but
> * gcc's 3.0 and earlier don't handle that correctly.
> */
> static char softirq_stack[NR_CPUS * THREAD_SIZE]
> __attribute__((__aligned__(THREAD_SIZE)));
>
> static char hardirq_stack[NR_CPUS * THREAD_SIZE]
> __attribute__((__aligned__(THREAD_SIZE)));
>
> With 8K stacks and NR_CPUS==128 that would be 2MB statically reserved. Yuck.
> Really needs to be dynamically allocated. I'll take a look once the .22
> big merge is done.
Here's what I did for i386 for someone concerned about blowing the stack.
-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Andi Kleen <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Jan Engelhardt <[email protected]>
- [6/6] arrange for a guard page on cpu 0's IRQ stack (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- [5/6] dynamically allocate IRQ stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- [4/6] go BUG on vmallocspace in __pa() (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- [3/6] make IRQ stacks independently configurable (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- [1/6] make stack size configurable (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)
- From: William Lee Irwin III <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- References:
- [-mm patch] i386: enable 4k stacks by default
- From: Adrian Bunk <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Zan Lynx <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: David Chinner <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Alan Cox <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Andi Kleen <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Christoph Hellwig <[email protected]>
- Re: [-mm patch] i386: enable 4k stacks by default
- From: Andi Kleen <[email protected]>
- [-mm patch] i386: enable 4k stacks by default
- Prev by Date: Re: BAD_SG_DMA panic in aha1542
- Next by Date: Re: vmstat: use our own timer events
- Previous by thread: Re: [-mm patch] i386: enable 4k stacks by default
- Next by thread: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)
- Index(es):
 |