On 28/04/07 23:37, Randy Dunlap wrote:
On Sat, 28 Apr 2007 17:44:42 +0100 Simon Arlott wrote:
The padlock.ko module is completely useless when compiled in
because it can't do anything and gets run too early to output
anything useful.
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -1,4 +1,6 @@
-obj-$(CONFIG_CRYPTO_DEV_PADLOCK) += padlock.o
+ifeq ($(CONFIG_CRYPTO_DEV_PADLOCK),m)
+obj-m += padlock.o
+endif
obj-$(CONFIG_CRYPTO_DEV_PADLOCK_AES) += padlock-aes.o
obj-$(CONFIG_CRYPTO_DEV_PADLOCK_SHA) += padlock-sha.o
obj-$(CONFIG_CRYPTO_DEV_GEODE) += geode-aes.o
I think that we prefer to enforce config symbols in Kconfig files,
not in Makefiles. E.g.,
No, that would cause the wrong behaviour in this case. The two
modules that depend on it for no reason work fine compiled in.
Ideally I'd just remove that module completely, all it does is
trigger the loading of the other two modules when modules are
used - so I'll submit a patch for that instead.
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2621-pv.orig/drivers/crypto/Kconfig
+++ linux-2621-pv/drivers/crypto/Kconfig
@@ -2,7 +2,7 @@ menu "Hardware crypto devices"
config CRYPTO_DEV_PADLOCK
tristate "Support for VIA PadLock ACE"
- depends on X86_32
+ depends on X86_32 && m
select CRYPTO_ALGAPI
default m
help
--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
