[PATCH] hugetlbfs: add NULL check in hugetlb_zero_setup()

If hugetlbfs module_init() fails, hugetlbfs_vfsmount
is not initialized and shmget() with SHM_HUGETLB flag will
cause NULL pointer dereference.

Cc: William Irwin <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>

Index: 2.6-mm/fs/hugetlbfs/inode.c
===================================================================
--- 2.6-mm.orig/fs/hugetlbfs/inode.c
+++ 2.6-mm/fs/hugetlbfs/inode.c
@@ -740,6 +740,9 @@ struct file *hugetlb_zero_setup(size_t s
 	char buf[16];
 	static atomic_t counter;
 
+	if (!hugetlbfs_vfsmount)
+		return ERR_PTR(-ENOENT);
+
 	if (!can_do_hugetlb_shm())
 		return ERR_PTR(-EPERM);
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] hugetlbfs: add NULL check in hugetlb_zero_setup()
    • From: William Lee Irwin III <[email protected]>

• References:
  • [PATCH] hugetlbfs: fix error path in module_init
    • From: Akinobu Mita <[email protected]>
  • Re: [PATCH] hugetlbfs: fix error path in module_init
    • From: William Lee Irwin III <[email protected]>
  • Re: [PATCH] hugetlbfs: fix error path in module_init
    • From: Akinobu Mita <[email protected]>

• Prev by Date: Re: [PATCH] deflate inflate_dynamic too
• Next by Date: Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)
• Previous by thread: Re: [PATCH] hugetlbfs: fix error path in module_init
• Next by thread: Re: [PATCH] hugetlbfs: add NULL check in hugetlb_zero_setup()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]