> > The warning is bogus imho. How do you write recovery code for internal > > broken code logic? > > Yes, it is marginal. But people do very often reach for BUG_ON() where > they could have at least partly recovered in some fashion - enough for the > info to hit the logs so we have a better chance of fixing it. At least one way to handle BUG_ON() type situations more cleanly (for some anyway) is to fake a hot-unplug/plug event. Thats something that would be nice to get into the PCI code as it'll let you recover from many things (even in some cases hardware fails if you go via D3). Does need some supporting logic (eg for networking to get back with the same config and online) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: checkpatch, a patch checking script.
- From: Andi Kleen <[email protected]>
- Re: checkpatch, a patch checking script.
- References:
- [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Martin Schwidefsky <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Andrew Morton <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Randy Dunlap <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Andrew Morton <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Andrew Morton <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Dave Jones <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Randy Dunlap <[email protected]>
- Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
- From: Andrew Morton <[email protected]>
- checkpatch, a patch checking script.
- From: Dave Jones <[email protected]>
- Re: checkpatch, a patch checking script.
- From: Andrew Morton <[email protected]>
- Re: checkpatch, a patch checking script.
- From: Andi Kleen <[email protected]>
- Re: checkpatch, a patch checking script.
- From: Andrew Morton <[email protected]>
- [PATCH 0/9] Kconfig: cleanup s390 v2.
- Prev by Date: Re: [RFC][PATCH] ChunkFS: fs fission for faster fsck
- Next by Date: Re: [00/17] Large Blocksize Support V3
- Previous by thread: Re: checkpatch, a patch checking script.
- Next by thread: Re: checkpatch, a patch checking script.
- Index(es):