The rwsem is not used to protect anything, so the use of it by the PNP subsystem isn't really useful, and it's doubtful if it really did anything or not. So I've removed it. Cc: Adam Belay <ambx1@neo.rr.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/pnp/card.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c index 91c047a..dd6384b 100644 --- a/drivers/pnp/card.c +++ b/drivers/pnp/card.c @@ -311,7 +311,6 @@ done: return NULL; found: - down_write(&dev->dev.bus->subsys.rwsem); dev->card_link = clink; dev->dev.driver = &drv->link.driver; if (pnp_bus_type.probe(&dev->dev)) @@ -319,14 +318,11 @@ found: if (device_bind_driver(&dev->dev)) goto err_out; - up_write(&dev->dev.bus->subsys.rwsem); - return dev; err_out: dev->dev.driver = NULL; dev->card_link = NULL; - up_write(&dev->dev.bus->subsys.rwsem); return NULL; } @@ -340,11 +336,9 @@ void pnp_release_card_device(struct pnp_dev * dev) struct pnp_card_driver * drv = dev->card_link->driver; if (!drv) return; - down_write(&dev->dev.bus->subsys.rwsem); drv->link.remove = &card_remove; device_release_driver(&dev->dev); drv->link.remove = &card_remove_first; - up_write(&dev->dev.bus->subsys.rwsem); } /* -- 1.5.1.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 24/46] Input: serio - do not touch bus's rwsem
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 24/46] Input: serio - do not touch bus's rwsem
- References:
- [GIT PATCH] Driver core patches for 2.6.21
- From: Greg KH <gregkh@suse.de>
- [PATCH 01/46] driver core: fix device_add error path
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 02/46] driver core: fix namespace issue with devices assigned to classes
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 03/46] dev_printk and new-style class devices
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 05/46] driver core: Use attribute groups in struct device_type
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 06/46] Driver core: add name to device_type
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 07/46] kobject: kobject_shadow_add cleanup
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 08/46] driver core: per-subsystem multithreaded probing
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 09/46] powerpc: make it compile for multithread change
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 10/46] driver core: don't fail attaching the device if it cannot be bound
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 11/46] Driver core: remove unneeded completion from driver release path
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 12/46] kref: fix CPU ordering with respect to krefs
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 13/46] Driver core: notify userspace of network device renames
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 14/46] Driver core: suppress uevents via filter
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 15/46] Driver core: switch firmware_class to uevent_suppress.
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 16/46] uevent: use add_uevent_var() instead of open coding it
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 17/46] Driver core: add suspend() and resume() to struct device_type
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 18/46] Kobject: kobject_uevent.c: Collapse unnecessary loop nesting (top_kobj)
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 19/46] kobject: kobject_add() reference leak
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 20/46] Driver core: remove use of rwsem
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 21/46] SCSI: use the proper semaphore to protect the class lists
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [PATCH 22/46] USB: remove use of the bus rwsem, as it doesn't really protect anything.
- From: Greg Kroah-Hartman <gregkh@suse.de>
- [GIT PATCH] Driver core patches for 2.6.21
- Prev by Date: [PATCH 45/46] drivers/base/attribute_container.c: use mutex instead of binary semaphore
- Next by Date: [PATCH 18/46] Kobject: kobject_uevent.c: Collapse unnecessary loop nesting (top_kobj)
- Previous by thread: [PATCH 22/46] USB: remove use of the bus rwsem, as it doesn't really protect anything.
- Next by thread: [PATCH 24/46] Input: serio - do not touch bus's rwsem
- Index(es):
![]() |