Re: [PATCH] serial 8250: move push calls out of lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Corey Minyard wrote:
Russell King wrote:

Use of an uninitialised variable.  The reason we use check_modem_status
to return the current status here is because reading the MSR _clears_
interrupts.  So, repeatedly calling get_mctrl via an ioctl is a great
way to introduce a hardware race condition if you just read the MSR and
never act on it.
"status" is used as a return variable; it is set by the call.  I modified
check_modem_status() to return if it detected a change and set the
status if it was passed in.
Ok, I see what I missed.  Never mind.

-corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux