On Fri, 2007-04-27 at 14:40 +0200, Pavel Machek wrote: > > Five callbacks are fine by me, especially if we can define reasonable defaults > > for the hibernation (and can we?). > > Well, we still can default to suspend(PMSG_FREEZE) for freeze(), and > resume() for thaw(). Anything else is just not sane way forward. I think we should remove the argument to suspend() in the same patch series. Yes, that would mean porting all drivers that currently use it, but that's not actually all that many since most drivers are dumbed-down wrt. power management. And realistically, resume for thaw makes no sense, nor does suspend for freeze, so we probably want to change those over to suspend/restart and use them. or something. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: driver power operations (was Re: suspend2 merge)
- From: Pavel Machek <[email protected]>
- Re: driver power operations (was Re: suspend2 merge)
- References:
- Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
- From: Linus Torvalds <[email protected]>
- Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
- From: Pavel Machek <[email protected]>
- driver power operations (was Re: suspend2 merge)
- From: Johannes Berg <[email protected]>
- Re: driver power operations (was Re: suspend2 merge)
- From: "Rafael J. Wysocki" <[email protected]>
- Re: driver power operations (was Re: suspend2 merge)
- From: Pavel Machek <[email protected]>
- Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
- Prev by Date: [GIT-PULL] please pull UBI tree
- Next by Date: Re: Back to the future.
- Previous by thread: Re: driver power operations (was Re: suspend2 merge)
- Next by thread: Re: driver power operations (was Re: suspend2 merge)
- Index(es):