Re: [PATCH] use mutex instead of semaphore in RocketPort driver

Am Dienstag, 24. April 2007 19:49 schrieb Matthias Kaehlcke:
> @@ -1706,7 +1706,7 @@ static int rp_write(struct tty_struct *tty,
>         if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
>                 return 0;
>  
> -       down_interruptible(&info->write_sem);
> +       mutex_lock_interruptible(&info->write_mtx);

This is a bug. It is also present in the current code, but nevertheless
it is a bug. If you use an interruptible lock, you must be ready to deal
with interrupts, which are ignored by this code.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] use mutex instead of semaphore in RocketPort driver
    • From: Matthias Kaehlcke <[email protected]>

• References:
  • [PATCH] use mutex instead of semaphore in RocketPort driver
    • From: Matthias Kaehlcke <[email protected]>

• Prev by Date: Support for Zilog or Infineon hardware?
• Next by Date: [git patches] net driver fixes
• Previous by thread: [PATCH] use mutex instead of semaphore in RocketPort driver
• Next by thread: Re: [PATCH] use mutex instead of semaphore in RocketPort driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]