On Tue, 24 Apr 2007 12:23:04 +0200
Olivier Galibert <[email protected]> wrote:
> Sorry for replying to Alan's reply, I missed the original mail.
>
> > > +#define ata_id_has_AN(id) \
> > > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
>
> (a && ~a) & (b & 32)
>
> I don't think that does what you think it does, because at that point
> it's a funny way to write 0 ((0 or 1) binary-and (0 or 32)).
>
> I'm not even sure what it is you want. If for the first part you
> wanted (id[76] != 0x00 && id[76] != 0xff), please write just that,
> thanks :-)
>
> OG.
>
>From the serial ata spec, we have:
13.2.1.18 Word 78: Serial ATA features supported
If Word 76 is not 0000h or FFFFh, Word 78 reports the optional features
supported by the device. Support for this word is optional and if not
supported the word shall be zero indicating the device has no support for new
Serial ATA capabilities.
so, basically yes, I'm really testing to make sure that word 76 isn't 0 or all
one then using that value & with value of bit in work 78 to determine AN
support - if you think this is really obfuscated, I've got no problem changing
it - there's obviously many ways to mess around with bits.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
