Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.

I get this, across netconsole:

[17179569.184000] console handover: boot [earlyvga_f_0] -> real [tty0]

wanna take a look at why there's cruft in bootconsole->name please?

-EFULL ;)

"earlyvga" is 8 chars. struct console->name is char[8]. No space left for the trailing ´\0´, the cruft comes from the next field (write function pointer). Obviously nobody ever printed the early console names before.

Hmm. We can make the names shorter. We can make the name field longer (probably 16, it ends up taking that much anyway due to aligments at least on 64bit). This looks best to me. We could also use printk("%.8s",name) to make printk stop after 8 chars, but I somehow don't like hardcoding the length like this ...

cheers,
  Gerd


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
    • From: Andrew Morton <[email protected]>

• References:
  • Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [ANNOUNCE] UidBind LSM 0.1
• Next by Date: NFS: Unable to handle kernel NULL pointer dereference at nfs_set_page_dirty+0xd/0x5d in 2.6.21rc7-git6
• Previous by thread: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
• Next by thread: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]