> Ahh, now I see; I had totally blocked out these few lines: > > pages_written += write_chunk - wbc.nr_to_write; > if (pages_written >= write_chunk) > break; /* We've done our duty */ > > yeah, those look dubious indeed... And reading back Neil's comments, I > think he agrees. > > Shall we just kill those? I think we should. Athough I'm a little afraid, that Akpm will tell me again, that I'm a stupid git, and that those lines are in fact vitally important ;) Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Andrew Morton <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- References:
- [PATCH 00/10] per device dirty throttling -v5
- From: Peter Zijlstra <[email protected]>
- [PATCH 10/10] mm: per device dirty threshold
- From: Peter Zijlstra <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Neil Brown <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Peter Zijlstra <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Miklos Szeredi <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Peter Zijlstra <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Miklos Szeredi <[email protected]>
- Re: [PATCH 10/10] mm: per device dirty threshold
- From: Peter Zijlstra <[email protected]>
- [PATCH 00/10] per device dirty throttling -v5
- Prev by Date: Re: [PATCH 8/8] Per-container pages reclamation
- Next by Date: Re: [Devel] [PATCH -mm] utrace: fix double free re __rcu_process_callbacks()
- Previous by thread: Re: [PATCH 10/10] mm: per device dirty threshold
- Next by thread: Re: [PATCH 10/10] mm: per device dirty threshold
- Index(es):